Skip to content

feat: add C ndarray API and refactor blas/ext/base/dnansumors #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 26, 2024
Merged

feat: add C ndarray API and refactor blas/ext/base/dnansumors #3001

merged 9 commits into from
Oct 26, 2024

Conversation

headlessNode
Copy link
Member

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C ndarray API and refactor/cleanup blas/ext/base/dnansumors

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Oct 11, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Oct 11, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Oct 11, 2024
@kgryte
Copy link
Member

kgryte commented Oct 11, 2024

@headlessNode Do you know the reason for the lint failure on CI?

@headlessNode
Copy link
Member Author

@kgryte I tried to find it in this PR but didn't find anything in the C files that could be causing this.

@Planeshifter
Copy link
Member

@headlessNode @kgryte To me, it looks like the C lint failures are due to cppcheck installation failing. Could have to do with latest GitHub Actions runner upgrade. Failures are not due to changes in this PR and are occurring in other PRs as well. We may need to look into the compilation failures. Upgrading cppcheck to a newer version could also be explored.

@gunjjoshi gunjjoshi mentioned this pull request Oct 13, 2024
Merged
1 task
@headlessNode headlessNode requested a review from kgryte October 23, 2024 06:53
kgryte
kgryte approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some additional updates, some of which may have been missed in previous reviews. LGTM. Thanks, @headlessNode!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Oct 26, 2024
@kgryte
Copy link
Member

kgryte commented Oct 26, 2024

@Planeshifter Upgrading cppcheck seems to have caused other build failures when linting C files. The failing build does not appear to be due to changes in this PR. As such, I will go ahead and merge.

@kgryte kgryte merged commit 7df5877 into stdlib-js:develop Oct 26, 2024
10 of 11 checks passed
@headlessNode headlessNode deleted the dnansumors-refactor branch October 27, 2024 08:55
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Nov 9, 2024
@headlessNode @kgryte @Neerajpathak07
feat: add C ndarray API and refactor blas/ext/base/dnansumors
2a7f55b 
PR-URL: stdlib-js#3001
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
@headlessNode @kgryte @aayush0325
feat: add C ndarray API and refactor blas/ext/base/dnansumors
6e3c3d7 
PR-URL: stdlib-js#3001
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@headlessNode @kgryte @Planeshifter @stdlib-bot